Repository navigation
Auto-assign distinct project ids on project insert - #58
Merged
Merged
Conversation
The Import Single form blocked submit on the blank required Project Id, and multi-row imports gave every row the same id.
labkey-bpatel
approved these changes
Sep 23, 2026
labkey-martyp
commented
Sep 23, 2026
labkey-martyp
left a comment
labkey-martyp
left a comment
Contributor
Author
There was a problem hiding this comment.
tests clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
New projects could not be entered through the Import Data page, and multi-row imports gave every project the same Project Id. The Import Single form treated the blank Project Id as a required field and blocked submit, even though the trigger assigns it; that trigger then reused one id for every row in an import, which breaks updates and deletes by key.
Related Pull Requests
None.
Changes