Skip to content

Remove ETL-only logic from protocolAssignment trigger #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-martyp merged 1 commit into from
Oct 13, 2026
Merged

Remove ETL-only logic from protocolAssignment trigger #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 0 additions & 122 deletions nbri_ehr/resources/queries/study/protocolAssignment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,125 +4,3 @@
* Licensed under the Apache License, Version 2.0: http://www.apache.org/licenses/LICENSE-2.0
*/
require("ehr/triggers").initScript(this);
var protocolData = {};
var prevAnimalId;
var prevDate;

var missing = [];

var count = 0;

function getLastAssignment(id){
var batchLastDate;

LABKEY.Query.selectRows({
schemaName: 'study',
queryName: 'protocolAssignment',
columns: 'Id,date',
filterArray: [LABKEY.Filter.create('Id', id)],
sort: '-date',
success: function (results) {
if (results.rows.length) {
batchLastDate = results.rows[0].date;
}
},
scope: this
});

return batchLastDate;
}

function onInit(event, helper){

if (helper.isETL()) {
LABKEY.Query.selectRows({
schemaName: 'ehr',
queryName: 'protocol',
columns: 'title,objectid',
success: function (results) {
if (results.rows.length) {
for (var i = 0; i < results.rows.length; i++) {
let rec = results.rows[i];
protocolData[rec.objectid] = rec.title;
}
}
},
scope: this
});
}
}

EHR.Server.TriggerManager.registerHandlerForQuery(EHR.Server.TriggerManager.Events.BEFORE_INSERT, 'study', 'protocolAssignment', function (helper, scriptErrors, row, oldRow) {

if (helper.isETL()) {
var isTransfer = prevAnimalId === row.Id;

if (row.remark) {
var remarkTextArr = row.remark.split(':');
var toProtocol = remarkTextArr[3].split(' (')[0]; // Get "To Protocol:" value without segment
var protocolId;

protocolId = getProtocolIdByName(toProtocol);
if (!protocolId || protocolId === 'undefined') {
if (missing.indexOf(toProtocol) === -1)
missing.push(toProtocol)
}
else {
row.protocol = protocolId;
}
if (isTransfer) {
if (row.enddate) {
// End date will initially have animal death/departure. Override if the transfer is older.
var death = new Date(row.enddate);
var prev = new Date(prevDate);

// Sanity check
if (prev < death) {
row.enddate = prevDate;
}
}
else {
row.enddate = prevDate;
}
}
else if (count === 0) {
// This handles batch boundary row for full truncate ETL, which is the only ETL setup for this currently.
// Gets previous date from db for first row in batch
var batchLastDate = getLastAssignment(row.Id);
if (batchLastDate) {
row.enddate = batchLastDate;
}
}

if (row.enddate === 'undefined') {
console.log("end date not found for animal event - " + row.animalEventId);
}
}

prevAnimalId = row.Id;
prevDate = row.date;
count++;
}

});


function getProtocolIdByName(protocolName) {
var protocols = Object.keys(protocolData);

// Search protocols for exact case-insensitive match
for (var i = 0; i< protocols.length; i++) {
var pName = protocolData[protocols[i]] ;
if (pName && protocolName.trim().toLowerCase() === pName.toString().toLowerCase()) {
return protocols[i];
}
}

// If exact match not found, search for partial match at beginning of protocol
for (i = 0; i< protocols.length; i++) {
pName = protocolData[protocols[i]] ;
if (pName && protocolName.trim().toLowerCase().indexOf(pName.toString().toLowerCase()) === 0) {
return protocols[i];
}
}
}
Loading