Repository navigation
GH Issue 1631: ViewContext.getString() (#8118) - #8124
Merged
labkey-adam merged 1 commit intoOct 2, 2026
Merged
Conversation
## Rationale Stop repeated URL parameters from causing unhandled ClassCastExceptions ([GH Issue 1631](LabKey/internal-issues#1631)). ## Changes - Introduce `ViewContext.getString()` which checks the value type before returning it. It returns `null` or a `String`, or else it throws a clear `BadRequestException`, which avoids logging and mothership reporting. - Use this safer method in `StudyController`, `ReportsController`, `AnnouncementsController`, etc. - Simple unit test for getString() - Introduce `ViewContext.get(String)` and deprecate `ViewContext.get(Object)`
labkey-adam
requested review from
labkey-jeckels,
labkey-klum and
labkey-matthewb
October 1, 2026 18:22
labkey-matthewb
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Backport to 26.10