Don't bypass file containment checks for disabled file roots. - #8131
Open
labkey-klum wants to merge 6 commits into
Open
labkey-klum wants to merge 6 commits into
labkey-klum wants to merge 6 commits into
Conversation
labkey-alan
approved these changes
Oct 5, 2026
labkey-alan
left a comment
labkey-alan
left a comment
Contributor
There was a problem hiding this comment.
The fixes look correct to me
labkey-nicka
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1463
Introduces a new service method to return configured file root paths regardless of whether the root has been disabled at the folder level. This closes off the primary vulnerability for the above issue. Also added an additional check in
DownloadFileLinkActionto ensure the table column requested has the same property URI specified on the request.Related Pull Requests
LabKey/testAutomation#3224