Bundle Windows runtime DLLs and bump ladybug to 0.20.4 - #24
Merged
Merged
Conversation
- Stage lbug_shared.dll, networkit_state.dll (+ extensions), and arrow.dll (+ vcpkg transitive deps) into src-tauri/windows-dlls/ and ship them next to the exe via bundle.resources, fixing the missing-DLL startup failure on Windows (MSI + NSIS). - build.rs copies the staged DLLs next to the exe for dev runs. - Bump lbug 0.18.1 -> 0.20.4, icebug crate 13.0.0 -> 13.2.0 (prebuilt default 13.0 -> 13.2), app version -> 0.20.4. Fixes #23
…MSYS2 mirrors, 404s rapidjson build)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23.
Windows MSI/NSIS installers were missing native runtime DLLs (
lbug_shared.dll,arrow.dll,networkit_state.dll), so the installed app failed to start. Tauri v2 only ships the exe plusbundle.resources— DLLs next to the exe are not picked up automatically.scripts/stage_windows_dlls.shcollectslbug_shared.dll,networkit_state.dll(+ leiden extension DLLs), andarrow.dll(+ vcpkg transitive deps) intosrc-tauri/windows-dlls/tauri.conf.jsonmaps it via"resources": { "windows-dlls": "" }so both MSI and NSIS install the DLLs next to the exe (map-with-empty-target flattens to filenames; empty dir is skipped on macOS/Linux)build.rscopies the DLLs next to the exe on Windows forcargo tauri dev