Repository navigation
Review the docs before launch - #34
Merged
Merged
Conversation
Fix the facts the three-pass review found, tighten the pages that said more than they needed to, and make the site hold up on a phone. Guides: the five "Add a" guides now match code that builds and passes on a fresh solution, including the operation count test, the Lambda Invoke wrapper, the MCP tool's XML docs and icon, and the GraphQL snapshot copy. Make it yours is split under three headings and its tables are lists. Set up CI leads with the pipeline a solution ships with, then lists every check the template runs on itself, what each one needs and which to leave out, so an engineer extending the minimal pipeline has the menu in one place. How it's built keeps the rules on main, the releases and the docs. Facts: one solution name throughout, migration namespace and BOM, HTTPS redirection behind a proxy, which Infrastructure classes are internal, the Scalar authentication section, the reviews_list arguments and the service name default. Design: a long inline code chip wraps like text and a short one stays whole, tables scroll on a phone, the header and sidebar take less room and the GitHub link shows on small screens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The three-pass review of the live site, applied. Every fact the review caught is corrected (the five "Add a" guides now match code that builds and passes on a fresh solution of each template, one solution name throughout, migration namespace and BOM, HTTPS behind a proxy, what's
internalin Infrastructure, the Scalar section name, thereviews_listarguments), the pages that said more than they needed to are shorter, and the site holds up on a phone.Set up CI now leads with the pipeline a solution ships with and why it's minimal, then lists every check the template runs on itself, what each needs and which to leave out, so an engineer extending the pipeline has the menu on one page. How it's built keeps the rules on main, releases and docs. Make it yours is split under three headings with its tables turned into lists. A long inline code chip wraps like text and a short one stays whole (a small Sätteri hast plugin marks the long ones), tables scroll on narrow screens, and the header and sidebar take less room.
Related issues
Follows LeanMeanCleanApps/.github#78. Touches LeanMeanCleanApps/.github#104 without closing it: How it's built now points at Set up CI for the checks, and the About page is still to come.
Type of change
@astrojs/markdown-satteriadded as a direct dependency; it already ships inside Astro 7)Checklist
npm run buildpasses and the link check reports every internal link valid.dotnet build,dotnet testanddotnet format --verify-no-changespass on all five.expose-a-use-caseskill is updated in its own PR, since the guide fix exposed that it skippedInvoke.