Repository navigation
ci: enforce the self-hosted fleet label contract - #14
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
A self-hosted job whose runs-on omits the fleet label matches no scale-up queue. It therefore never spawns its own runner: it can only land on an instance another job happened to create, and otherwise sits queued until GitHub's 24-hour timeout. That is how the org-wide main-source-gate stalled, and how unmatched events fell through to the on-demand queue. The webhook matcher matches exactly against a fixed label set ([self-hosted, linux, x64, aws] and its siblings), so the label is load-bearing rather than cosmetic. Nothing enforced it. scripts/fleet-label-guard.py parses each workflow and fails when a self-hosted runs-on carries no fleet label. It skips non-self-hosted runners, non-Linux self-hosted runners such as macOS, and expressions that resolve at runtime. Wired into organization-pr-baseline.yml as a blocking step, placed after PyYAML is installed. Depends on #13: main-source-gate omits the label today, so this check is red until #13 lands. The branch is based on #13 for that reason.
Aurora Capital (auroracapital)
force-pushed
the
ci/fleet-label-guard
branch
from
October 17, 2026 11:33
6ad80d7 to
0c30f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waarom
Een self-hosted job waarvan
runs-onhet fleet-label mist, matcht geen enkele scale-up queue. Hij maakt dus nooit een eigen runner: hij kan alleen landen op een instance die een andere job toevallig maakte, en zit anders in de wachtrij tot GitHub's 24-uurs timeout.Dat is precies hoe het misging:
main-source-gatebleef hangenDe webhook-matcher matcht exact tegen een vaste labelset (
[self-hosted, linux, x64, aws]en varianten), dus het label is functioneel, niet cosmetisch. Niets dwong het af.Wat deze PR doet
scripts/fleet-label-guard.pyparset elke workflow en faalt als een self-hostedruns-ongeen fleet-label heeft.Overgeslagen (met reden):
${{ ... }}expressies, want die resolven pas at runtimeToegevoegd als blocking stap in
organization-pr-baseline.yml, direct na de PyYAML-installatie.Bewijs
Guard op de huidige workflows:
Negatieve test op een expres kapotte workflow:
De goede, macOS- en dynamische jobs werden correct overgeslagen.
actionlintlokaal: exit 0.Let op: afhankelijk van #13
main-source-gatemist vandaag het label, dus deze check is rood tot #13 landt. Deze branch is daarom op #13 gebaseerd. Merge #13 eerst.Context
Onderdeel van de ephemeral runner optimalisatie. Item #3 uit het voorstel: het labelcontract afdwingbaar maken in plaats van een afspraak.