Repository navigation
Conversation
fix: Fixing compilation fix: Retrying write operations only after repositioning the drive
madjesc
requested review from
XV02 and
syaoraang
and removed request for
syaoraang
October 2, 2026 20:45
XV02
requested changes
Oct 6, 2026
XV02
left a comment
XV02
left a comment
Contributor
There was a problem hiding this comment.
Waiting for the rest of the changes still pending as we discussed
- clear the previous power on reset status and retry - retry in both ibmtape netbsd driver and the sg one - make _clear_por return an int fix: minor changes chore: revert separation of por and allocation issues feat: make block failure generic
fix: Avoiding hidding cdb_write return code fix: Using correct return value to check write output
fix: Attending Missael's requests fix: Attending Missael's requests fix: write soft error handling (POR and transport failures) Fix: start_block misalignment caused by SIGSTOP (LinearTapeFileSystem#552) fix: start_block misalignment caused by position mismatch LinearTapeFileSystem#11 fix: Fixing compilation fix: Fixing compilation chore: Attending Japan team comments * Handling better the return code that was forcefully set as DEVICE_GOOD * Renaming _handle_block_write_failure() to _resolve_position_after_io_cmd_failure() to reduce naming concerns and yet don't repeat code. We don't take inconsideration the EDEV_BUFFER_ALLOCATE_ERROR when called by -EDEV_HOST_ERROR since it doesn't affect that path. fix: Avoiding shadowing the _cdb_write() return value if _clear_por() return value is not DEVICE_GOOD. Fixing in scsipi_ibmtape.c file an issue where the ret_write wasn't changed never but returned anyways. chore: Adding log to mention the retry due the POR chore: Attending Japan team comments on POR issue PR
Implement dylan suggestion Co-authored-by: DYLAN CARLSON <dcarlso@us.ibm.com>
fix: write soft error handling (POR and transport failures)
chore: make readability better Implement dylan suggestion Co-authored-by: DYLAN CARLSON <dcarlso@us.ibm.com> fix: readibility fix: write soft error handling (POR and transport failures) fix: set SP bit fix: add read retry
madjesc
force-pushed
the
fix/write-soft-err
branch
4 times, most recently
from
October 7, 2026 18:19
9cebb06 to
b3b9049
Compare
madjesc
force-pushed
the
fix/write-soft-err
branch
from
October 7, 2026 18:19
b3b9049 to
7ee5419
Compare
amissael95
reviewed
Oct 8, 2026
| * specific mode page | ||
| * Right now SDE and LE does not set any non savable pages, but this could change. | ||
| * */ | ||
| cdb[1] = 0x11; |
Contributor
There was a problem hiding this comment.
@madjesc I believe it would be helpful to write a short comment about why we are enabling SP bit now
amissael95
reviewed
Oct 8, 2026
| cdb[1] = 0x10; /* Set PF bit */ | ||
| /* | ||
| * Set PF and SP bit | ||
| * NOTE: Not all modepages support SP bit. |
Contributor
There was a problem hiding this comment.
Now, it is affecting all modes pages, I think it would be useful to only enable SPI bit for READ_WRITE_CTRL page, which is the one that include Append-Only Mode (AOM) and Allow Overwitte modes as we talked.
Additionally, you already have a list of the modepages used by LTFS, where I think SP is supported, so this comment is a bit misleading, could you check it and add that mode pages list in the PR description?
amissael95
approved these changes
Oct 9, 2026
amissael95
left a comment
amissael95
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, if possible just address the comments to make these changes and PR more descriptive.
XV02
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue description
When writting data to a tape, at random moments, a Power-On-Reset (POR) event could occurs, which would stop the operation and make the write fail, affecting the user experience.
This PR fixes this issue by performing a retry when a POR is detected. This retry will be performed at most 3 times and in different timelapses, giving time the hardware to be ready to continue.