Skip to content

feat(lsp): decide declaration or usages; references can leave the declaration out #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1lck merged 1 commit into from
Nov 12, 2026
Merged

feat(lsp): decide declaration or usages; references can leave the declaration out #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions rust/contracts/rust-core-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,6 +1806,20 @@ isReadOnly }` where `classification` is `workspace`, `externalReadOnly` (a
source file of the language that produced the jump, opened read-only) or
`rejected`. See `rust/fixtures/lsp/navigation-target-v1.json`.

`lsp.declarationOrUsages` accepts `{ uri, position, definitions }`: the
document and zero-based `{ line, utf16Column }` of a go-to-declaration gesture
(caret or clicked character) and the definition answer received for it, each
`{ uri, range }` (at most 100). It returns `{ action }`: `usages` when every
definition location is the gesture's own place, otherwise `definitions`,
including an empty answer, which hosts report as no definition. A location is
the gesture's own place when its `uri` equals `uri` and its range contains the
position, end included, because an editor resolves the identifier left of the
caret. This is IntelliJ IDEA's Go to Declaration or Usages: on `usages` the host
asks for `references` with `includeDeclaration: false`, opens a single usage
directly, lists several and reports none. Every gesture that goes to a
declaration (Cmd/Ctrl+B, Cmd/Ctrl+click, F12, the editor menu) uses this
decision. See `rust/fixtures/lsp/declaration-or-usages-v1.json`.

`editor.parseNavigationInput` accepts `{ text }` and returns `{ target }`.
`target` is null for invalid input, otherwise `{ line, column, selectsWholeLine }`
contains zero-based line and UTF-16 column. One-based positive decimal line and
Expand Down Expand Up @@ -4839,6 +4853,12 @@ The result is `{ symbols: WorkspaceSymbolItem[] }`, where each item is
server's `workspaceSymbol/resolve` supplies it, which Core does not call. Items
without `name` or `location.uri` are dropped.

Operation `references` (`textDocument/references`) accepts optional
`includeDeclaration` (boolean), sent as LSP `params.context.includeDeclaration`.
Missing means `true`, the previous behaviour; the usages shown from a
declaration (`lsp.declarationOrUsages`) pass `false` so the language server
leaves the declaration out. Other operations ignore the field.

Completion requests accept optional `completionContext` with LSP `triggerKind`
(`1` invoked, `2` trigger character, `3` incomplete-list refresh) and
`triggerCharacter` (required and one character for kind `2`). Missing context
Expand Down
Loading
Loading