Repository navigation
feat(logging): 新增增量更新暂存清理失败事件 update.delta.cleanup_failed - #40
Merged
Merged
Conversation
桌面客户端用补丁重建的新版本放在临时目录,安装后、版本被替换或窗口关闭时删除; 删除失败按日志规则必须记录,目录里没有合适的事件。WARN,字段 error。
xiaoyumuxi
marked this pull request as ready for review
November 14, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联
接着 #38:桌面端(Viva 客户端)的增量更新会先用补丁在系统临时目录里重建新版本(Viva
update.ApplyPatch的暂存目录),再交给安装器。这个目录只用一次,以下三种情况都要删掉:删除失败不属于日志规则的四类豁免,必须记录,但目录里没有合适的事件:
update.rollback.cleanup_failed专指稳定版回退。app.storage.cleanup_failed专指 Core 存储。改动
rust/logging/events/update.json新增update.delta.cleanup_failed:warn,通道update,消息Staged delta update payload cleanup failed,限速 60/分钟,ownerLithe。error(error,必填):删除临时目录里那份重建的应用时返回的文件系统错误。os.RemoveAll对不存在的目录返回 nil),不记这个事件。node scripts/logging/generate-log-events.mjs重新生成rust/crates/diagnostics/src/catalog_generated.rs,只多出这一个事件。验证
node scripts/logging/generate-log-events.mjs --check:通过,共 211 个事件(update=7)。cargo test -p lithe-diagnostics:69 个测试通过。不涉及插件契约、能力版本或插件函数协议,不需要更新协议记录。合入后桌面端把
PINNED_CORE_REVISION升到合入后的提交。