Added Missing return Type to bit32.replace - #3464
Open
Pspritechologist wants to merge 1 commit into
Open
Pspritechologist wants to merge 1 commit into
Pspritechologist wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
中文:该改动为 bit32.replace 添加了 ---@return integer 注解,与 bit32.extract 的文档风格一致,且符合 Lua 5.2+ 中 bit32.replace 返回整数的实际行为,未发现 bug、安全或回归问题。
English: This change adds a ---@return integer annotation to bit32.replace, consistent with the documentation style of bit32.extract and matching the actual behavior of bit32.replace returning an integer in Lua 5.2+, with no bugs, security, or regression issues found.
中文:审查总结:改动仅涉及类型注解(meta/template 文件),属于纯文档/类型信息补充,不影响运行时逻辑,风险极低,可以合并。
English: Review summary: The change only touches a type annotation in a meta/template file, purely supplementing documentation/type information without affecting runtime logic. Risk is minimal and it can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs state here that the function
Returns a copy ....