Skip to content

Added Missing return Type to bit32.replace - #3464

Open
Pspritechologist wants to merge 1 commit into
LuaLS:masterfrom
Pspritechologist:missing_return
Open

Pspritechologist wants to merge 1 commit into
LuaLS:masterfrom
Pspritechologist:missing_return

Conversation

@Pspritechologist

Copy link
Copy Markdown

The docs state here that the function Returns a copy ....

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文:该改动为 bit32.replace 添加了 ---@return integer 注解,与 bit32.extract 的文档风格一致,且符合 Lua 5.2+ 中 bit32.replace 返回整数的实际行为,未发现 bug、安全或回归问题。
English: This change adds a ---@return integer annotation to bit32.replace, consistent with the documentation style of bit32.extract and matching the actual behavior of bit32.replace returning an integer in Lua 5.2+, with no bugs, security, or regression issues found.

中文:审查总结:改动仅涉及类型注解(meta/template 文件),属于纯文档/类型信息补充,不影响运行时逻辑,风险极低,可以合并。
English: Review summary: The change only touches a type annotation in a meta/template file, purely supplementing documentation/type information without affecting runtime logic. Risk is minimal and it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant