Skip to content

Read 2D chemistry probe species after locating the probe #2065

Open

Description

@sbryngelson

In the 2D branch of s_write_probe_files the species partial densities
were read from q_cons_vf(j-2, k-2, l) before j, k and l were computed
for the current probe and outside the ownership check, so they used the
previous probe's cell or, for the first probe, uninitialized indices.
A gfortran debug run of a 2D chemistry case with probes aborted on an
out-of-bounds index.

Move the read inside the ownership branch after the indices are set,
as in the 1D and 3D branches.


A fix for this is already written. The pull request was closed only to reduce the number of simultaneously open PRs from this author, not because the work was rejected or found incorrect.

Tracked with the pr-to-do label so the whole set is discoverable together.

Filed with Claude Code.

Activity

  1. added
    pr-to-doFix already written in a closed PR; reopen when review capacity allows
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pr-to-doFix already written in a closed PR; reopen when review capacity allows

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions