Repository navigation
Use the ghost-cell spacing for the z one-sided viscous gradient - #1991
Draft
sbryngelson wants to merge 3 commits into
Draft
sbryngelson wants to merge 3 commits into
sbryngelson wants to merge 3 commits into
Conversation
s_compute_fd_gradient's one-sided z derivative at idwbuff(3)%beg divided by z_cc(beg + 2) - z_cc(is3_viscous%beg). is3_viscous%beg is idwbuff(3)%beg + 1 there, so the denominator spanned one cell instead of two and the outermost ghost gradient was doubled on a uniform grid. Divide by z_cc(beg + 2) - z_cc(beg), matching the x and y stencils. The 27 3D Viscous tests pass against the existing goldens.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s_compute_fd_gradient's one-sided z derivative at idwbuff(3)%beg
divided by z_cc(beg + 2) - z_cc(is3_viscous%beg). is3_viscous%beg is
idwbuff(3)%beg + 1 there, so the denominator spanned one cell instead
of two and the outermost ghost gradient was doubled on a uniform grid.
Divide by z_cc(beg + 2) - z_cc(beg), matching the x and y stencils.
The 27 3D Viscous tests pass against the existing goldens.