Repository navigation
fix(items): give the season 6 armor sets 47 and 48 the names of the client - #1486
Merged
Merged
Conversation
…lient The armor sets 47 and 48 were initialized with each other's name, and three pieces of the set 47 were spelled "Destory". The client data (english, korean and japanese item files of the 1.04d client, and the MuMain item data) calls the set 47 Phantom and the set 48 Destroy, so the admin panel showed the other set's name than the game. The pieces now use the Phantom and Destroy resources, with the "Destory" keys renamed; the set bonuses, which are named after the armor, follow. German names follow the name, Chinese names stay with the item number, as they were already right. The optional update plugin renames the pieces and the set bonuses of existing configurations. Names which were changed in the configuration are kept. Fixes MUnique#1483
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 29 |
| Duplication | 11 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
sven-n
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1483
The season 6 armor sets 47 and 48 were initialized with each other's name, and three pieces of the set 47 were spelled "Destory". The client calls 47 Phantom (armor drop level 131, defense 80) and 48 Destroy (drop level 125, defense 66): see the english
item_eng.bmd, the korean and japanese item files of the 1.04d client, and MuMain'ssrc/bin/Data/Items/Group08..11*.json. So the admin panel showed the other set's name than the game.docs/ItemNameLocalization.mdalready noted the swap.Changes
Phantom*resources, number 48 theDestroy*resources. TheDestory*keys are renamed toDestroy*, with the spelling fixed.ArmorSetNameskeys.ArmorInitializerBase.GetSetNameis nowinternal, so the update reuses it.FixDestroyPhantomArmorNamesPlugIn(season 6, optional): renames the pieces and the set bonuses of existing configurations. It only touches names which still have the previous built-in text, so customized names are kept. Applying it twice changes nothing.SocketSystem.csand the paragraph indocs/ItemNameLocalization.mdare updated.Testing
FixDestroyPhantomArmorNamesTest:dotnet test tests/MUnique.OpenMU.Persistence.Initialization.Tests: 840 passed, 12 skipped (the[Ignore]PostgreSQL ones), 0 failed.