Repository navigation
Conversation
Each timely region is a full subgraph with its own progress tracker and progress exchange, and the scheduler visits it several times per tick. Compute rendering only uses regions to group operators, so run every region body in the enclosing scope and make entering and leaving the identity. Operators are unchanged, only the region scopes disappear. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute rendering wraps imports, objects, let bindings, the main body, and joins, reduces, top-k and sinks in timely regions. Each region is a full subgraph with its own progress tracker and all-worker progress exchange, so a frontier advance is propagated and broadcast once per region it crosses, on every worker. For replicas with many idle dataflows this per-tick bookkeeping dominates CPU, and it grows with the worker count rather than with data.
This change renders those regions inline: the closure runs in the enclosing scope and entering or leaving is the identity, through crate-local
inline_named,enter_inlineandleave_inlineinrender/inline_region.rs. Operators are unchanged.BuildRegionstays a real region, because index importsenterit from the dataflow scope.Measured locally on 16 workers with static tables ticking once per second,
upstream/mainagainst this branch: 48 dataflows go from 1.38 to 1.00 cores (-28%), 426 dataflows from 12.5 to 8.4 cores (-32%), with scopes dropping from 7,968 to 2,252, reachability log records by 82%, and hydration from about 65 s to 50 s. Lag is unchanged.Introspection gets shallower:
mz_dataflow_addressesandmz_dataflow_operator_parentslose the region levels, the dataflow visualizer nests less, andmz_lir_mappingoperator ranges cover fewer operators.introspection/relations.sltchanges accordingly. Testdrive files that inspect operator addresses may need updates once CI runs them.🤖 Generated with Claude Code