Repository navigation
test_symbols: reset the session at the end, so its definitions do not leak into other tests - #2048
Merged
Merged
Conversation
…o not leak test_symbols.py sets a = 2, f[x_] := x^2 and g[f] ^:= 2 and leaves them in the shared test session. Run before test_testing_expressions.py, it made 8 cases there fail (Xor[a], SubsetQ[f[a, b, c], f[a]], EvenQ[f[2]], ...). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/builtin/symbol/test_symbols.pysetsa = 2,f[x_] := x^2andg[f] ^:= 2and leaves them in the session that all the unit tests share. Whentest/builtin/test_testing_expressions.pyruns after it, 8 cases there fail, becauseXor[a]becomesXor[2],EvenQ[f[2]]evaluatesf[2], and so on:The usual ordering of the full suite hides this, but other orderings (or a run of a subset of directories) expose it.
The fix adds a
(None, None, None, None)case at the end of the list, which resets the session, as intest/test_context.py.Tests: the two files above now give 119 passed. The full pytest suite gives 0 failures.
🤖 Generated with Claude Code