Repository navigation
Misc cleanups noticed via recent PRs - #2049
Merged
Merged
Conversation
* Add some expected_args * convert some typing.List and typing.Tuple to "list" and "tuple" * Add more function type annotations * Change some @lru_cache to @cache
tombouctou
approved these changes
Oct 19, 2026
tombouctou
left a comment
tombouctou
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Checked: the dropped SymbolDifferentialD/SymbolIntegral in calculus.py have no other users; the expected_args for Accuracy/Precision (1) and IntegerExponent (1, 2) match WMA's argx/argt messages; the elements→get_elements() changes in nevaluator.py and @lru_cache()→@cache keep the same behavior. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.