Repository navigation
Исправить Docker-сборку фронтенда и проверять её до деплоя - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Деплои после PR #49 и #50 падают на установке frontend-зависимостей: Docker использует
pnpm install --frozen-lockfile, но в pnpm-lock.yaml отсутствуют добавленные в package.json пакеты markdown-it и @types/markdown-it. CI проходил, поскольку устанавливал зависимости из package-lock.json через npm.Обновлён pnpm-lock.yaml с сохранением версий ранее зафиксированных пакетов. В CI добавлена отдельная обязательная для успешного workflow сборка настоящего frontend Dockerfile без публикации образа: рассинхронизация pnpm-lock.yaml теперь обнаруживается до слияния.
Проверка: исходная ошибка воспроизведена pnpm 12.16.1; после обновления frozen-install и production build проходят, 1050 тестов в 131 файле проходят на установленных через pnpm зависимостях. Docker-сборку проверяет новая CI job.
Сбой: https://github.com/MegaBadCoder/tracker/actions/runs/41851484449
Предыдущий аналогичный сбой: https://github.com/MegaBadCoder/tracker/actions/runs/39151600504