Repository navigation
Repeater coverage lines: a switch, off by default - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs MeshMapper/MeshMapper_Project#601 (reopened from the app: "Issue still there").
What
Selecting a repeater draws a dashed line from it to every square that heard it (up to 5000). Near a busy repeater the lines bury the squares. The web already lets you hide them (its "Repeater Coverage" layer); the app had no way to.
New switch: Settings > Map > Coverage Overlay > Repeater Coverage Lines, off by default.
mmRedrawSelectedCoverageparity). Settings is a tab over the still-mounted map, so this applies while Settings is open.How
UserPreferences.showRepeaterCoverageLines(JSON pref, default false) with its own settersetShowRepeaterCoverageLines. It calls plainnotifyListeners(), not_notifyMapNow()and notupdatePreferences(which rebuilds the map and clears the antenna/power restored flags).MapWidgetapplies a flip from a direct provider listener,_onRepeaterCoverageLinesNotify, like the opacity slider._drawRepeaterCoveragekeeps the drawn lines in_repeaterCoverageLines(cleared with the cells in_clearCoverageCellsand on style reload), so a flip can redraw or clear them. It still ensures the lines layer before the cells layer, so layer order is unchanged.repeaterCoverageLinesAfterSwitchincoverage_summary.dart: redraw, clear, or leave the layer alone (no repeater coverage drawn, a tapped tile owns the layer, or the lines belong to another repeater).DEVELOPMENT.md"Coverage Connection Lines" documents the switch and corrects the repeater cap (5000, not 250).Checks
flutter analyze: no issuesflutter test: all pass (2548, 1 skipped), including the newtest/models/user_preferences_repeater_coverage_lines_test.dartandtest/utils/repeater_coverage_lines_test.dartdart format. Edited files are hand-formatted to match the surrounding style.Release note
Existing users lose the lines on update, so the note should name the switch, e.g. "Repeater coverage lines are now off by default. Turn them back on in Settings > Map > Repeater Coverage Lines."
Wiki: MeshMapper/MeshMapper_Wiki#41 (Settings Reference entry and the Tap a repeater note)