Fix release Java selection and cached CodeQL builds - #495
Merged
SkyBlade1978 merged 2 commits intoOct 1, 2026
Merged
SkyBlade1978 merged 2 commits into
SkyBlade1978 merged 2 commits into
Conversation
Use Temurin 17.0.1+12 for both release builds and Maven publication, matching the existing build guard. Add a workflow check so the release selector cannot drift back to a floating Java 17 version. The new check failed before the change and passes afterward.
Disable Gradle build-cache reuse in the CodeQL compile step so the scanner observes javac, even when production sources have not changed. The workflow guard reproduces the missing setting and passes with the fix; a clean no-cache compilation passes too.
SkyBlade1978
changed the title
SkyBlade1978
merged commit Oct 1, 2026
9edbb6f
into
MinecraftModDevelopmentMods:master-1.12
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow problems surfaced during final release checks.
The new workflow checks failed against the old settings and pass with these fixes. A clean no-cache compilation passes locally, along with check, build, Javadocs, release artifact auditing, and Eclipse isolation. This PR changes only workflows and their checks; gameplay, dependency versions, and release version are unchanged.