Skip to content

Publish the Apple silicon build as Lantern-mac-arm64.zip for the updater - #30

Merged
gitsad merged 3 commits into
mainfrom
feat/mac-arm64-release-asset
Nov 10, 2026
Merged

gitsad merged 3 commits into
mainfrom
feat/mac-arm64-release-asset

Conversation

@gitsad

@gitsad gitsad commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

What this changes

Every release now carries a third asset, Lantern-mac-arm64.zip, a byte-identical copy of the signed and notarized Lantern-mac.zip. The updater service update.electronjs.org files a darwin zip under darwin-arm64 only when its name contains -arm64, so until now Apple silicon got a 404. The Lantern-mac.zip download link is unchanged.

Key files

  • .github/workflows/release.yml — new publish-job step before the release is created: fails if release-assets/Lantern-mac.zip is missing, then copies it to Lantern-mac-arm64.zip; the existing release-assets/* --clobber upload picks it up. No second build or signing.
  • test/release-workflow.test.ts — parsed-YAML guards: the copy step exists, runs before the upload and fails on a missing source; upload is the whole folder with --clobber; the two build artifacts keep their names; the publish job builds, signs and reads no secret.
  • README.md, docs/installation.md — state the extra file and that the Lantern-mac.zip link stays the one to use.

Before / after

Before: release assets Lantern-mac.zip, Lantern-win-x64.zip; /darwin-arm64/<version> answers 404.
After: Lantern-mac.zip, Lantern-mac-arm64.zip, Lantern-win-x64.zip. Rule checked in electron/update.electronjs.org src/asset-platform.ts: /.*-(mac|darwin|osx).*\.zip$/i plus /-arm64/ gives DARWIN_ARM64, else x64.

Verified with pnpm run typecheck, pnpm run lint, pnpm test, all green. The release workflow itself was not run (it needs a real tag). Unreviewed fixes: none. Lantern: 2 files re-mapped.

Run cost

agent model effort calls cache-read cache-write+input
lantern-delegate-medium sonnet 5.5 medium 59 8701794 159953
└ reviewer ×1 opus 5.5 medium 10 510601 77480
total 69 9212395 237433

🤖 Generated with Claude Code

@gitsad
gitsad merged commit 6756e5b into main Nov 10, 2026
16 checks passed
@gitsad
gitsad deleted the feat/mac-arm64-release-asset branch November 10, 2026 18:29
@gitsad gitsad mentioned this pull request Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant