Repository navigation
Publish the Apple silicon build as Lantern-mac-arm64.zip for the updater - #30
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Every release now carries a third asset,
Lantern-mac-arm64.zip, a byte-identical copy of the signed and notarizedLantern-mac.zip. The updater serviceupdate.electronjs.orgfiles a darwin zip underdarwin-arm64only when its name contains-arm64, so until now Apple silicon got a 404. TheLantern-mac.zipdownload link is unchanged.Key files
.github/workflows/release.yml— new publish-job step before the release is created: fails ifrelease-assets/Lantern-mac.zipis missing, then copies it toLantern-mac-arm64.zip; the existingrelease-assets/* --clobberupload picks it up. No second build or signing.test/release-workflow.test.ts— parsed-YAML guards: the copy step exists, runs before the upload and fails on a missing source; upload is the whole folder with--clobber; the two build artifacts keep their names; the publish job builds, signs and reads no secret.README.md,docs/installation.md— state the extra file and that theLantern-mac.ziplink stays the one to use.Before / after
Before: release assets
Lantern-mac.zip,Lantern-win-x64.zip;/darwin-arm64/<version>answers 404.After:
Lantern-mac.zip,Lantern-mac-arm64.zip,Lantern-win-x64.zip. Rule checked inelectron/update.electronjs.orgsrc/asset-platform.ts:/.*-(mac|darwin|osx).*\.zip$/iplus/-arm64/givesDARWIN_ARM64, else x64.Verified with
pnpm run typecheck,pnpm run lint,pnpm test, all green. The release workflow itself was not run (it needs a real tag). Unreviewed fixes: none. Lantern: 2 files re-mapped.Run cost
🤖 Generated with Claude Code