Repository navigation
chore: prune pointless e2e tests and wire every spec into a script - #32
Merged
Merged
Conversation
…e9fe4fe46a2 # Conflicts: # .lantern/map/.lantern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Removes four e2e tests that proved nothing about the app, and gives every remaining Playwright spec a
package.jsonscript so none is orphaned.Key files
test/e2e/graph-performance.spec.ts,.mdandtest:graph:perf— removed (no latency budget, could not catch a slowdown)test/e2e/graph-regression.spec.ts,graph-navigation.spec.ts,tray-popover.spec.ts— one guard-mismatch test, one hidden-harness test and the two logo tests removedpackage.json— newtest:graph:macro:e2e,test:pr-review:e2e,test:text-select:e2e,test:lsp:e2e(compiles first)docs/primitives.md— the four scripts listed under Regression checksBefore / after
Before: 12 of 24 specs had no script. After: a shell check that every
test/e2e/*.spec.tsbasename appears inpackage.jsonprints nothing missing.First run of each new script (these specs were never run by anything, and several fail on their own, not fixed here):
test:graph:macro:e2e: 28 passed, 13 failed (30 s timeouts in graph-macro-areas, -foundation, -legend, -platform-uses, -systems)test:pr-review:e2e: 5 passed, 5 failedtest:text-select:e2e: 7 skipped (no Playwright Chromium)test:lsp:e2e: failed, the spec's esbuild build has no.svgloader (prdiffmodal.ts)Also:
test:graph:e2e33 passed, 9 failed (screenshot and attribute checks, not touched by this change);test:tray:e2e11 passed;test:graph:typecheckalready fails onorigin/main(64 errors,getBitmap()typed void in graph-pixi, missing svg declarations).Verified with
pnpm run typecheck,pnpm run lint,pnpm test(7004 passed), all green. Unreviewed fixes: none. Reviewer follow-ups, not done:launchTrayHarnessviewport/scaleandGraphHarness.startupMsare now unused. Lantern: 4 files re-mapped.Run cost