Repository navigation
Conversation
…background A right-click on a node selected it and started a scroll animation that fought the right-drag pan.
They open the Overview drawer, scope to the visible review body, pick the Explain intent, read data-tip and skip the hidden drawer aside.
… strip The baselines predate 752fdf31, which dropped the Pull requests label and moved the strip to the app bar.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
test:graph:macro:e2e,test:pr-review:e2eandtest:graph:e2enow exit zero on macOS (41, 10 and 42 tests, each run twice in a row). Of the 27 failing tests, 25 were stale specs (the UI had moved on) and are updated to the current behaviour; 1 was a real app bug (a right-click on a graph node selected it), fixed in the app; 2 were stale pixel baselines, regenerated because of a deliberate redesign. Nothing is skipped, fixme'd or retried, no fixed timeout was added.Key files
src/renderer/lib/lantern-pixi/open-actions.ts,node-graphics.ts,relation-graphics.ts,index.ts— a newisPrimaryTapguards every Pixipointertaphandler (node, tile, block, relation area, background). A right or middle click used to select the node under the pointer and start the animated scroll, which fought the right-drag pan.test/e2e/support/overview.ts— opens and closes the Macro Overview drawer, which is hidden by default and now holds the chips, legend and details the macro specs read.test/e2e/graph-macro-*.spec.ts,pane-overflow.spec.ts,support/overflow.ts— read the drawer through that helper, and check it for clipped text.test/e2e/pr-review-comments.spec.ts,pr-review-regions.spec.ts,graph-navigation.spec.ts,graph-pixi.spec.ts— scoped selectors and the tooltip attribute (see the table).test/e2e/snapshots/darwin/pixi-overview.png,pixi-selected.png— regenerated withtest:graph:visual:update.Before / after
Baseline on untouched
main(macro 28 pass / 13 fail, pr-review 5 / 5, graph 33 / 9), one line per failing test:.lt-sidematch hung the click.lt-side.first()hit its hidden twin.lt-cm-cardof.lt-review-body, which is the hidden body (rect 0); now scoped to the visible body.lt-side(strict mode); now.lt-side:not(.lt-overview), the app's own selector.lt-sidematchtitletodata-tip(two assertions)#id · state · fileschip); the baseline dates from d34dd491 (2026-10-07)No test was deleted. Missing baseline: none missing, two stale.
Verified with
pnpm install --frozen-lockfile,pnpm run typecheck,pnpm run lint,pnpm test(7004 pass), and each of the three e2e scripts exit zero twice in a row. Unreviewed fixes: none after the reviewer (VERDICT merge-with-followups, BLOCKING 0; the map commit and the run-folder removal came after,chore: update the Lantern map). Decisions the brief left open: the snapshots were regenerated (the 752fdf31 evidence above).pnpm run test:graph:typecheckalready fails onmainand is untouched. Primitives: composed thetest:*:e2eentries and the graph harness; no gap. Lantern: 16 files re-mapped.Run cost
🤖 Generated with Claude Code