Repository navigation
Read each local of a declaration list as the literal it starts from - #222
Merged
estebanzimanyi merged 1 commit intoOct 29, 2026
Conversation
_notnull_default reads the initializer of a local up to the comma of a declaration of several locals, as _guarded_default reads it: `int nrows = 0, ncols = 0;` starts nrows from 0, where it read `0, ncols = 0` and stated no literal. Raster_set_values reads the size of its flags into both locals only where argument 5 is not NULL, so the call leaving its flags to their default NULL binds nosetheight 0 beside nosetwidth 0 and noset NULL. A local starting from a call keeps stating none. Witness: tests/test_boundargs.py DeclarationListTests, the locals of Raster_set_values; the first test fails on master. Why: J15d of MobilityDB #2861, setValues(raster, integer, integer, integer, float[]), which the typed JVM surfaces leave unregistered while the catalog binds nosetwidth and not nosetheight for it. Measured: over the headers MobilityDB master 96f10bdac8 installs, the catalog changes only in the nullDefaultBinds of setValues, which gains nosetheight 0. The 601 tests pass, master's 599 and the 2 above. Over this catalog, JMEOS codegen/two-dimensional-array-input registers the call without the flags, 9585 overloads against 9584.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_notnull_default reads the initializer of a local up to the comma of a declaration of several
locals, as _guarded_default reads it:
int nrows = 0, ncols = 0;starts nrows from 0, where itread
0, ncols = 0and stated no literal. Raster_set_values reads the size of its flags intoboth locals only where argument 5 is not NULL, so the call leaving its flags to their default
NULL binds nosetheight 0 beside nosetwidth 0 and noset NULL. A local starting from a call keeps
stating none.
Witness: tests/test_boundargs.py DeclarationListTests, the locals of Raster_set_values; the
first test fails on master.
Why: J15d of MobilityDB #2861, setValues(raster, integer, integer, integer, float[]), which the
typed JVM surfaces leave unregistered while the catalog binds nosetwidth and not nosetheight
for it.
Measured: over the headers MobilityDB master 96f10bdac8 installs, the catalog changes only in
the nullDefaultBinds of setValues, which gains nosetheight 0. The 601 tests pass, master's 599
and the 2 above. Over this catalog, JMEOS codegen/two-dimensional-array-input registers the
call without the flags, 9585 overloads against 9584.