Repository navigation
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c111bc88b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| const after = toPublicEntry(entry); | ||
| if (plan.forceEmit === true || !publicEntriesEqual(before, after)) { | ||
| const suppressRetryStatus = event.type === 'retryDue' || (automaticRetry && plan.target === 'retryWaiting'); |
There was a problem hiding this comment.
When a credential event such as tokens-saved arrives while an automatic retry is connecting, WorkspaceMcpService.handleMcpOAuthEvent sees pending and waits for a non-pending onStatusChange notification before invoking reconnectAfterCurrent (packages/agent-core-v2/src/workspace/workspaceMcp/workspaceMcpService.ts:214-231). If that handshake fails transiently, this condition suppresses the resulting retryWaiting/failed notification, so the credential change is not redriven until a later automatic attempt emits; with the default backoff this can delay OAuth completion by several minutes. Preserve a settle signal for internal waiters even if duplicate user-facing statuses are hidden.
Useful? React with 👍 / 👎.
Requirement or Bug
将本期
release/2026-10-28的 2.4.0 版本元数据、CHANGELOG、已消费 changesets 和 release-only 修复同步回main，避免下一期发版基准漂移。本 PR 提前以 Draft 开出，必须在全部发布与验收步骤完成后才能转为 Ready / 合并。Bug Reproduction Steps
N/A
Root Cause
N/A
Code Changes
ef3422209b…（fix(agent-core-v2): suppress automatic MCP retry status repeats #4492）：带回仅存在于本期 release 的 MCP 自动重试状态去重修复，保留 main 后续测试增强。f26e4d91ef…（ci: release packages #4463）：同步 CLI 2.4.0、VS Code 0.8.4、SDK 0.22.0、pi-tui 0.86.0 及对应 CHANGELOG，并删除 main 上已被本期版本消费的 36 个 changesets。0b8b5d8f…（multi-source-folder workspaces），该提交不在 app 本期 release0ca916b71a…的祖先链上。用 release dist 覆盖会丢失 main 的后续功能，因此保留 main 的apps/kimi-code/dist-web原样。+105/-193：36 个已消费 changesets、8 个版本/CHANGELOG 文件和 fix(agent-core-v2): suppress automatic MCP retry status repeats #4492 的 2 个源码/测试文件；无 lockfile 或 main 后续功能回退。Behavior Changes and Affected Users
验证：
apps/kimi-code/dist-web相对origin/main零 diff。packages/agent-core-v2的test/mcpCore/connection-manager.test.ts：46/46 通过。pnpm run build全量通过；Web assets 检查通过。Checklist
gen-changesetsskill, or this PR needs no changeset. (Release sync only; consumed changesets are removed, no new changeset)gen-docsskill, or this PR needs no doc update. (Docs changelog is handled separately in docs(changelog): sync 2.4.0 from apps/kimi-code/CHANGELOG.md #4496)