Repository navigation
Use KSPUtil.SanitizeString() to sanitize vessel filenames - #2391
Merged
Merged
Conversation
This means that existing crafts which have e.g. spaces will have their configs reset to default once. Makes MJ consistent with how the rest of KSP operates. Makes filenames consistent across different O/S (copy GameData between operating systems and it should be consistent). Fixes a bug in the factory reset function to clean up configs correctly and to not use the KSP.IO functions that throw on other bad DLLs because they walk the assembly tree. closes #1909
Contributor
✅ Build Artifact 🚀MechJeb2-ecafee0.zip (built from 44d10c1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that existing crafts which have e.g. leading or trailing whitespace will have their configs reset to default once.
Makes MJ consistent with how the rest of KSP operates.
Makes filenames consistent across different O/S (copy GameData between operating systems and it should be consistent).
Fixes a bug in the factory reset function to clean up configs correctly and to not use the KSP.IO functions that throw on other bad DLLs because they walk the assembly tree.
closes #1909