You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
NodeNorm preferred name chooser retains the overly small length bug #396
Babel's preferred name chooser had a bug (now fixed in NCATSTranslator/Babel#725) caused by it applying the downgrading of overly long labels when choosing a preferred name to all taxa, causing problems in UMLS, disease and phenotype branches which have long labels that should be used. That PR changed the behavior so that the long labels would only be downgraded in ChemicalEntity identifiers. An example:
{{BabelTest|HasLabel|MONDO:0031219|mismatch repair cancer syndrome}}
As of #386, NodeNorm has replaced its own preferred name chooser by importing and using Babel's preferred names instead. However, the existing preferred name chooser may still be used if no preferred label exists on a clique (this shouldn't happen, but I've opened NCATSTranslator/Babel#940 to figure out if it does happen).
Eventually (hopefully soon) we'll just eliminate it entirely with #299, but this issue (1) tracks that this code branch is still live and has a bug on it, and so will need to be fixed if we ever need to reactivate it, and (2) can be used in tests to use the existence of this bug as a way to ensure that the Babel preferred name is being used.
Activity