Repository navigation
fix: group rejection not filtering out invalid records correctly - #175
Merged
stevenhsd merged 2 commits intoOct 8, 2026
Conversation
stevenhsd
reviewed
Oct 8, 2026
| if node.parent_entity and node.mandatory: | ||
| entity_issues_found[node.parent_entity] = process_node(node) | ||
| result = process_node(node) | ||
| if result and not entity_issues_found.get(node.parent_entity): |
Contributor
There was a problem hiding this comment.
do we need the 2nd part of this condition?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR of changes
Fixed an issue where group rejections were not filtering the output entity correctly due to bool check was only showing the last check it performed rather than whether a group rejection had been identified.
What kind of changes does this PR introduce?
Tick all that apply
Please check if the PR fulfills these requirements