Skip to content

fix: refactor the join_header method in duckdb to deal with out of bound date values - #177

Merged
georgeRobertson merged 1 commit into
release_v010from
fix/gr-ndsp-678-issues_with_very_old_or_future_dates_crashing_with_join_header
Oct 9, 2026
Merged

georgeRobertson merged 1 commit into
release_v010from
fix/gr-ndsp-678-issues_with_very_old_or_future_dates_crashing_with_join_header

Conversation

@georgeRobertson

Copy link
Copy Markdown
Contributor

TLDR of changes

bug with existing join_header logic where the duckb -> polars -> python would crash as the year 0000 would result in a datetime validation error. Have removed the dependency of needing to move to polars and python meaning this should no longer crash.

What kind of changes does this PR introduce?

Tick all that apply

  • fix: A bug fix. Correlates with PATCH in SemVer
  • feat: A new feature. Correlates with MINOR in SemVer
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
  • ci: Changes to CI configuration files and scripts (example scopes: GitLabCI)

Please check if the PR fulfills these requirements

  • I have read and followed the Contributing guidance
  • Docs have been added / updated
  • Tests and Linting in the CI are passing
  • Changes have been reviewed and approved by a Project Maintainer

@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@georgeRobertson
georgeRobertson merged commit a32a01b into release_v010 Oct 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant