Skip to content

Remove remote default Structurizr theme - #12

Merged
james merged 1 commit into
mainfrom
fix/remove-remote-structurizr-theme
Oct 9, 2026
Merged

james merged 1 commit into
mainfrom
fix/remove-remote-structurizr-theme

Conversation

@james

@james james commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

This was generating an error message, but it wasn't necessary.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2026-10-09 13:02 UTC

@james
james requested a review from jabley October 9, 2026 12:29

@jabley jabley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, preview still looks the same and is functional.

@james
james merged commit 0483a88 into main Oct 9, 2026
2 checks passed
@james
james deleted the fix/remove-remote-structurizr-theme branch October 9, 2026 13:02
james added a commit that referenced this pull request Oct 9, 2026
Deploys from main have been no-ops since c2f2755 ("Don't overwrite
pr-preview in github pages"). That commit replaced `publish_dir: .`,
`exclude_assets` and `enable_jekyll` with `keep_files: true` and left
publish_dir unset. peaceiris/actions-gh-pages then defaults to
`./public`, which doesn't exist in this repo, so the job reports
success without publishing anything.

Result: merges to main (e.g. PR #12) never reached the live site; only
PR previews did.

Restore `publish_dir: .`, keeping `keep_files: true` so pr-preview/ is
preserved.

Broken by: c2f2755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants