Repository navigation
Publish repo root to gh-pages again (restore publish_dir) - #14
Merged
Merged
Conversation
Deploys from main have been no-ops since c2f2755 ("Don't overwrite pr-preview in github pages"). That commit replaced `publish_dir: .`, `exclude_assets` and `enable_jekyll` with `keep_files: true` and left publish_dir unset. peaceiris/actions-gh-pages then defaults to `./public`, which doesn't exist in this repo, so the job reports success without publishing anything. Result: merges to main (e.g. PR #12) never reached the live site; only PR previews did. Restore `publish_dir: .`, keeping `keep_files: true` so pr-preview/ is preserved. Broken by: c2f2755
|
Collaborator
Author
|
Sorry about the repeated reviews @jabley , only the merge to main is broken |
jabley
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploys from main haven't actually done anything since c2f2755. That commit replaced
publish_dir: .,exclude_assetsandenable_jekyllwithkeep_files: trueand left publish_dir unset. peaceiris/actions-gh-pages then defaults to./public, which doesn't exist in this repo, so the job reports success without publishing anything.