Skip to content

CCM-17942: Add Log Reference - #675

Open
nhsd-david-wass wants to merge 12 commits into
mainfrom
feature/CCM-17942-Log-References
Open

nhsd-david-wass wants to merge 12 commits into
mainfrom
feature/CCM-17942-Log-References

Conversation

@nhsd-david-wass

Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

DT3-Specific Checklist

  • If I have added a new resource (SQS, Lambda, Gateway, DDB table, etc), I have created the appropriate alarms

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-david-wass
nhsd-david-wass requested a review from a team as a code owner August 17, 2026 08:46
@nhsd-david-wass
nhsd-david-wass force-pushed the feature/CCM-17942-Log-References branch from fe450da to cfd08ff Compare August 17, 2026 13:26
@nhsd-david-wass
nhsd-david-wass requested a review from a team as a code owner August 17, 2026 13:26
@nhsd-david-wass
nhsd-david-wass force-pushed the feature/CCM-17942-Log-References branch 2 times, most recently from c0462be to 5998fe5 Compare August 18, 2026 07:59
@nhsd-david-wass
nhsd-david-wass force-pushed the feature/CCM-17942-Log-References branch 14 times, most recently from c84d281 to b53c3b9 Compare September 17, 2026 15:00
masl2
masl2 previously approved these changes Sep 25, 2026
Comment thread lambdas/supplier-allocator/src/services/supplier-config.ts Outdated
Comment thread lambdas/supplier-allocator/src/handler/allocation-config.ts Outdated
Comment thread lambdas/supplier-allocator/src/handler/allocation-config.ts Outdated
Comment thread lambdas/supplier-mock/src/handler/supplier-mock.ts

@RossFaulds171 RossFaulds171 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just found a few points where it hasn't replaced the description with the logrefs description

@nhsd-david-wass
nhsd-david-wass force-pushed the feature/CCM-17942-Log-References branch from 55e07c9 to 1b0879e Compare October 12, 2026 13:46
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants