Repository navigation
Conversation
Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
|
Resolved #185's integration conflicts in #191 already merged the production containment fix. This branch now preserves main's UUID filenames, validated extensions, exclusive writes, ownership-authorized downloads and current retry/deletion behavior. Its diff against main is only Verification on this head:
The traversal regression failed with outside-sentinel corruption under a controlled restoration of client-derived paths and nonexclusive writes. Both symlink tests failed when exclusive creation was removed. Those controls ran in a separate temporary copy; production source on this branch matches main. Focused tests use real filesystem operations and doubled persistence, with no live DynamoDB or deployment claim. The branch was updated without rewriting published history. Hosted checks and maintainer review still need to complete. |
The attachment-containment fix is now part of main through #191: upload basenames are server-generated UUIDs, only validated extensions are retained, and exclusive writes refuse existing destinations. This PR preserves that implementation and adds focused filesystem regressions.
The remaining diff is one test file,
backend/__tests__/messages.test.js. Coverage checks:Current main at
92cd98394ab830569b6316d7c2570ed4a8d2e48cwas incorporated through an append-only merge. Production source, safe-extension behavior, owner-authorized downloads, conversation deletion and retry behavior match main. All three PR commits carry DCO sign-offs, and the hosted DCO check passes.Validation rechecked on November 13, 2026, at
b3970af0dce5c10d978be8218a9411d49a148969:cd backend && npm test: 71 Node tests pass, one optional Redis integration test skips because its explicit service configuration is absent; all 86 Jest tests across 27 suites pass.Filesystem behavior is real; database persistence is doubled in the focused tests. This revision does not claim live DynamoDB, Redis integration or deployment verification. The PR is non-draft, conflict-free and ready for independent human review. Hosted backend regression, CodeQL and hardcoded-URL checks await maintainer authorization; local passing results do not replace those gates.
The contribution follows the fork/PR and per-commit DCO requirements in NTARI's Bug-Build-Test guide. No runtime or conformance binding changes are included. The author must not merge the PR.