Skip to content

Document the support boundary for legacy account verification - #203

Open
nirmalhk7 wants to merge 4 commits into
NTARI-RAND:mainfrom
nirmalhk7:nirmal/agrinet-legacy-verification-audit
Open

nirmalhk7 wants to merge 4 commits into
NTARI-RAND:mainfrom
nirmalhk7:nirmal/agrinet-legacy-verification-audit

Conversation

@nirmalhk7

@nirmalhk7 nirmalhk7 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

The legacy registration and verification helpers have no demonstrated supported caller in the application. This documentation-only PR records that support boundary in docs/LEGACY_ACCOUNT_VERIFICATION_AUDIT.md and links it from the backend README.

The audit is based on upstream main at e645b724109cc5c351676f6ac659737a3a64d82b, including the merged security hardening from #197. The actual non-minimal server mounts inline account handlers: /api/auth exposes register, login and test routes; /users exposes list and administrator-only provisioning. It does not load backend/controllers/user_controller.js. The registration response's instruction to verify email/phone is not evidence of a working verification endpoint.

The legacy controller is retained because an undocumented external consumer cannot be ruled out. Establishing a supported caller would require a new review and an agreed account-lookup/migration contract. #199 remains open with its proposed email claims, direct login lookup and backfill; #194 remains open with overlapping user-directory pagination. Their pending policy choices are not adopted here. The current baseline's single-page login lookup is a separate issue, not resolved by this reachability audit.

Verification

Rechecked head 56b126da820cd315b789175c9f3e7c3d308227f9 on November 16, 2026:

  • git grep -n -E 'user_controller|registerUser|verifyUser' HEAD -- backend frontend scripts finds only the two export declarations in the legacy controller.
  • Historical related-file lists in .github/ISSUE_TEMPLATE mention the controller path. The audit now explicitly distinguishes those references from runtime callers and support agreements; its source-search claim is scoped to backend, frontend and scripts.
  • Runtime inspection of the actual non-minimal server confirms both account routers are mounted with the documented methods and the legacy controller is absent from Node's module cache. Unrelated BullMQ constructors were replaced, startup intervals were cleared before firing, and network access was blocked for this inspection. Account routers and handlers were not replaced; no account writes were sent.
  • cd backend && npm test passes all 60 Node tests and all 65 Jest tests across 25 Jest suites. The successful run had local loopback access; the initial sandboxed run could not bind HTTP test listeners.
  • ./scripts/list-hardcoded-urls.sh passes.
  • git diff --check e645b724109cc5c351676f6ac659737a3a64d82b...HEAD passes. The complete PR diff contains only the audit and its README link.
  • All four PR commits carry DCO sign-offs. Hosted DCO, hardcoded-URL, backend-regression and CodeQL checks pass on published head a783c757bb99d9fd1a2111518cb83e76c3a2bff2. The documentation correction requires fresh hosted results after publication.

No runtime behavior, schema, API, identity policy, conformance binding or settlement mechanism changes are included. This PR does not implement account verification or claim to fix legacy lookup behavior. Lookup-beyond-first-page, uniqueness and ambiguous-account acceptance checks apply only if a supported legacy path is established.

The contribution follows the fork/PR and DCO requirements in NTARI's Bug-Build-Test guide. The PR is ready for independent human review; the author must not merge it. Slack task adoption/completion and forwarding receipts are separate workflow records and are not claimed by this PR.

Document that the non-minimal server mounts inline auth and user handlers
without loading the legacy registration or verification controller. Retire
conditional backlog item 07 for the inspected main snapshot, while keeping
undocumented external consumers and pending identity contracts explicit.

Link the audit from backend routing documentation. No runtime behavior,
account migration policy, or verification endpoint changes are included.

Validation: source and runtime reachability checks, complete backend test
suite, and full Qlty baseline/final comparison pass with no new findings.

Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Describe server reachability and support limitations directly so the audit
stands on its own. Preserve the findings and pending account-PR boundaries.

Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
@nirmalhk7 nirmalhk7 changed the title Document unreachable legacy account verification and retire conditional scope Document the support boundary for legacy account verification Nov 6, 2026
Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
@nirmalhk7
nirmalhk7 marked this pull request as ready for review November 11, 2026 23:39
Distinguish source searches from historical issue-template references. The template lists establish no runtime caller or support agreement; account behavior and migration boundaries remain unchanged.

Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant