Repository navigation
Conversation
Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
nirmalhk7
marked this pull request as ready for review
November 11, 2026 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
witnessd -seed-fileso operators can retain their witness identity without putting private seed bytes in process arguments or shell history. The file holds a 32-byte Ed25519 seed encoded as 64 hex digits. Invalid input fails startup without generating a replacement identity or printing seed contents.Linux and macOS require an effective-user-owned regular file with owner-only permissions. Checks and bounded reads use the same descriptor; final-component symlinks are refused. macOS also rejects extended ACLs through its native descriptor API and requires a cgo-enabled build. Other platforms and macOS builds without cgo refuse unchecked file loading. Existing
-seedusage remains compatible with a deprecation warning, conflicting nonempty options are rejected, and no-option demo mode remains explicitly ephemeral.Updates witness startup, operator documentation, and conformance notes. This persists key identity only: rollback memory remains ephemeral, and the change does not establish federation or a central registry. The protocol module and its dependency-leaf contract are unchanged.
Validation: startup regressions were observed failing before implementation, including a readable macOS ACL fixture, then passed. Stable public identity across restarts, malformed/oversized and insecure files, symlinks, secret-free diagnostics, and compatibility/demo behavior are covered. The full race-enabled Go suite, formatting, vet, build, Linux/Windows cross-builds, and macOS build without cgo passed. Current Janus document and invariant-ID binding checks passed; delegated gaps remain reported as such. Full Qlty scans introduced no new smells or check findings against the comparable uncapped baseline; existing findings remain.
Follows the Janus architecture and preserves the existing witness stand-in limitations.