Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 28, 2026 09:28
podman_preflight verifies that openshell-driver-podman fails fast when its Podman socket is unreachable. It only needs the standalone driver binary, not a gateway, so it never fit the gateway-backed e2e-podman harness it lived under and never ran anywhere in CI. Move it into crates/openshell-driver-podman/tests/ as a plain Cargo integration test. It now runs via the existing required workspace test job with no special mise task, workflow step, or coverage exception. Signed-off-by: politerealism <burdcat17@gmail.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
podman-preflight-tests/el
branch
from
September 28, 2026 19:18
593ab1e to
43d57e0
Compare
7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked follow-up to #3783. That PR now moves
podman_preflightinto the normalopenshell-driver-podmanintegration-test layer and makes its diagnostic assertion portable on macOS. This PR adds deterministic unit coverage for the driver's retry contract and reduces the executable coverage to one smoke test.This PR depends on #3783. Because #3783 originates from a fork, GitHub cannot use its head branch as this PR's base; #3783 head
b9c4f2cf7is nevertheless the direct parent of this PR's commit. Once #3783 merges, the displayed diff will collapse to only the retry-coverage follow-up.Related Issue
Related to #3712 and follows the ownership direction discussed on #3749.
Changes
Testing
mise run pre-commitpassescargo test -p openshell-driver-podman— 233 tests passedmise run test— blocked by an unrelated existingtasks/scripts/test-install-sh.shcommand-substitution syntax failure inlinux_package_methodChecklist