Repository navigation
fix(ci): keep release credentials out of the build checkout - #767
Open
yashrajp22 wants to merge 26 commits into
Open
yashrajp22 wants to merge 26 commits into
yashrajp22 wants to merge 26 commits into
Conversation
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
davidjmoorembaypn
approved these changes
Oct 6, 2026
support375
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release checkout leaves its write-scoped GitHub token in Git configuration while dependency installation and build tools run. Set
persist-credentials: falseso those steps do not inherit the stored credential; the release step continues to use its explicitGH_TOKEN. Also correct the pinned setup-uv action comment to its verified v5.4.2 tag.Follow-up to #746, which has already merged.
Validation: all 11 release workflow and helper tests pass against the current-main-based commit in an isolated container. Ruff lint and formatting checks pass.