Repository navigation
Conversation
Transformer Engine selects TF32 for pure FP32 GEMM, and the PyTorch references in the numerics tests do not. Where cuBLAS uses TF32, the FP32 cases fail on correct code. These launchers already set NVIDIA_TF32_OVERRIDE=0 for test_mhc.py for the same reason. Set it for the numerics tests too, so that the L0 launchers give the same result outside the CI image. Signed-off-by: Bruno Volpato <brunocvcunha@gmail.com>
7 of 13 tasks
5 of 13 tasks
bvolpato
marked this pull request as ready for review
November 3, 2026 02:53
Contributor
[Low impact] The PR appears safe to merge. SummaryDisables TF32 for three numerics test commands across the two L0 PyTorch launchers.
Reviews (1) · Last reviewed commit: "[CI] Disable TF32 for the L0 PyTorch num..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the L0 PyTorch numerics tests give the same result outside the CI image.
Transformer Engine selects TF32 for pure FP32 GEMM, and the PyTorch references in these tests do not use it. Where cuBLAS takes the TF32 path, FP32 cases in
test_numerics.pyandtests/pytorch/debug/test_numerics.pyfail on correct code, because the differences exceed the FP32 tolerances. The launchers already setNVIDIA_TF32_OVERRIDE=0fortest_mhc.pyfor the same reason.Type of change
Changes
NVIDIA_TF32_OVERRIDE=0for the numerics tests inqa/L0_pytorch_unittest/test.shandqa/L0_pytorch_debug_unittest/test.sh.Validation
Both launcher versions ran on NVIDIA B200 with CUDA 13.2, PyTorch 2.15.0+cu132, and no override in the environment. Without this change, FP32 cases fail in the
test_numerics.pycommand, and the debug launcher exits with an error. With this change, thetest_numerics.pycommand finds no failures, and the debug launcher exits successfully.test_numerics.pyshows the same failures on the same cases with PyTorch 2.11 and 2.13, and the override removes them.The environment of the CI image was not visible, so the reason that these tests pass there without this variable is not known. If the image already disables TF32, this change has no effect in CI. A100 and H100 were not tested.
Checklist: