Repository navigation
deploy_monitoring.sh: exit non-zero when the monitoring Helm release is not deployed - #1430
Merged
Merged
Conversation
…is not deployed Fail when helm upgrade fails or the release ends up in any state other than deployed, and retry a release left failed instead of skipping the install. Add a stubbed-helm test.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| STUB_LOG=self.log, STUB_STATE=self.state, **env) | ||
| r = subprocess.run(["bash", os.path.join(self.tmp, "scripts", "k8s", "deploy_monitoring.sh")], | ||
| cwd=self.tmp, env=e, capture_output=True, text=True, timeout=60) | ||
| calls = open(self.log).read() if os.path.exists(self.log) else "" |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| STUB_LOG=self.log, STUB_STATE=self.state, **env) | ||
| r = subprocess.run(["bash", os.path.join(self.tmp, "scripts", "k8s", "deploy_monitoring.sh")], | ||
| cwd=self.tmp, env=e, capture_output=True, text=True, timeout=60) | ||
| calls = open(self.log).read() if os.path.exists(self.log) else "" |
michael-balint
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script returned 0 even when the kube-prometheus-stack Helm release ended up failed, and skipped the install whenever any release existed (including a failed one).
helm upgrade --installfails.deployedstate afterwards.deployed.scripts/validation/tests/test_deploy_monitoring.py, using stubbed helm/kubectl (no cluster needed).Tested:
python3 -m unittest discover scripts/validation/tests(136 tests OK).