Repository navigation
Conversation
Use the Kubernetes node label for GPU Nodes server selection, resolving node-exporter through node_uname_info. Preserve inventory-address fallbacks for Slurm and check the dashboard queries with offline Prometheus fixtures. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix empty host panels in the GPU Nodes dashboard when Kubernetes GPU and node-exporter metrics use different scrape addresses.
Validation
python3 -m unittest discover -s tests/monitoring -vwith Prometheuspromtool3.5.0: 3 tests passed, covering four metric layouts and unrelated-node isolation. All panel expressions are parsed by Prometheus.python3 -m unittest discover -s scripts/validation/tests: 131 tests passed.git diff --check: passed.Notes
These are local JSON/query checks, not live Grafana confirmation. Kubernetes relies on the existing
kubernetes_nodeGPU scrape label andnode_uname_info.nodenamefor node identity. Existing dashboard imports or ConfigMaps need the updated JSON; the monitoring install script does not replace an existing dashboard ConfigMap.