Repository navigation
SCHOL-966: VQA/AQA round 2 - #213
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nprotheroNYPL
approved these changes
Sep 29, 2026
nprotheroNYPL
left a comment
nprotheroNYPL
left a comment
Contributor
There was a problem hiding this comment.
Looks good, when testing fullscreen in ES I noticed that there is a cut-off. But this is not just in this PR, it is also in our QA environment. Heres a image of how it looks for me:
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses VQA item 5, AQA items 1, 5, 7 from the QA doc.
minHeight={0}to the web reader manager wrapper since the defaultminHeightfor flex elements is"auto"which would cause the height of the reader to expand to the full height of the pdf content whenheight="100%"is passed to the web reader component.Tested locally in Enhanced Search (PR) and in the example app