Skip to content

Demo: simplify money() with round() — CI catches a half-cent bug #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NailKarimov wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Demo: simplify money() with round() — CI catches a half-cent bug #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions services/bookshop/pricing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Money rules of the bookshop. Kept apart from the web layer so they can be tested on their own (Hypothesis)."""

from decimal import ROUND_HALF_UP, Decimal
from decimal import Decimal

CENT = Decimal("0.01")
FREE_SHIPPING_FROM = Decimal("50.00")
Expand All @@ -9,8 +9,8 @@


def money(value: Decimal) -> Decimal:
"""Rounds to cents, half up (the way a till does), not banker's rounding."""
return value.quantize(CENT, rounding=ROUND_HALF_UP)
"""Rounds to cents."""
return round(value, 2)


def quote(lines: list[tuple[Decimal, int]], coupon: str | None = None) -> dict[str, Decimal]:
Expand Down
Loading