Skip to content

ci: bump setup-android to v4.0.4 so it stops installing the removed 'tools' package - #2049

Merged
edusperoni merged 1 commit into
mainfrom
fix/ci-setup-android-tools-package
Sep 22, 2026
Merged

edusperoni merged 1 commit into
mainfrom
fix/ci-setup-android-tools-package

Conversation

@edusperoni

@edusperoni edusperoni commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Problem

The NPM Release run for d0824c9 on main failed in both the Build and Test jobs at the "Setup Android SDK" step:

[command]/usr/local/lib/android/sdk/cmdline-tools/20.0/bin/sdkmanager tools
Warning: Failed to find package 'tools'
Error: The process '.../sdkmanager' failed with exit code 1

android-actions/setup-android v4.0.0 (the pinned SHA) installs tools platform-tools by default. Google has removed the legacy tools package from the SDK repository, so sdkmanager tools now exits 1 and every job dies before the NDK is even set up. Nothing in this repo changed; the last green run on 2026-09-11 used the same workflow.

Fix

Bump the pin to v4.0.4 (be39fa83) in all four usages across npm_release.yml and pull_request.yml. Upstream fixed exactly this in v4.0.2 ("Fix for removed tools package") by changing the default packages to platform-tools; v4.0.3/v4.0.4 are dependency and cmdline-tools updates.

Note: #2047 carries an equivalent workaround (with: packages: platform-tools on the old pin). Whichever lands second will need a trivial rebase of those hunks; this PR is the standalone fix so main is unblocked independently of that review.

Summary by CodeRabbit

  • Chores
    • Updated the Android setup used by automated build and test checks in both release and pull request workflows. The updated setup is applied consistently across their build and test stages. This change affects project verification and release preparation only; it does not change app features or behavior visible to end users.

…tools' package

setup-android v4.0.0 installs 'tools platform-tools' by default. Google has
dropped the legacy 'tools' package from the SDK repository, so sdkmanager
now exits 1 and every Build/Test job dies at "Setup Android SDK". v4.0.2
changed the default to 'platform-tools' only.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 3d4f045f-73a8-4360-9979-481f6e2ec1a9

📥 Commits

Reviewing files that changed from the base of the PR and between d0824c9 and 41d424e.

📒 Files selected for processing (2)
  • .github/workflows/npm_release.yml
  • .github/workflows/pull_request.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The pull request and NPM release workflows now use android-actions/setup-android v4.0.4 in their build and test jobs. No other behavior changes are reported.

Changes

Android Setup Action Update

Layer / File(s) Summary
Update workflow action versions
.github/workflows/pull_request.yml, .github/workflows/npm_release.yml
The build and test jobs in both workflows update android-actions/setup-android from v4.0.0 to v4.0.4.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: nathanwalker

Merge Risk: ⚪ Minimal · up to 41d42

The four build and test jobs now use the action version that avoids requesting the removed tools package by default. No merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: upgrading setup-android to v4.0.4 to fix the removed tools package issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the build,
Then hops to test the SDK.
Four point zero point four,
Now greets each workflow run.
The carrot patch approves!

Comment @coderabbitai help to get the list of available commands.

@edusperoni
edusperoni merged commit 1e7fc7a into main Sep 22, 2026
8 checks passed
@edusperoni
edusperoni deleted the fix/ci-setup-android-tools-package branch September 22, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant