ci: bump setup-android to v4.0.4 so it stops installing the removed 'tools' package - #2049
Conversation
…tools' package setup-android v4.0.0 installs 'tools platform-tools' by default. Google has dropped the legacy 'tools' package from the SDK repository, so sdkmanager now exits 1 and every Build/Test job dies at "Setup Android SDK". v4.0.2 changed the default to 'platform-tools' only.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe pull request and NPM release workflows now use ChangesAndroid Setup Action Update
Priority: ⬆️ High Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The four build and test jobs now use the action version that avoids requesting the removed 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the build, Comment |
Problem
The NPM Release run for d0824c9 on
mainfailed in both the Build and Test jobs at the "Setup Android SDK" step:android-actions/setup-androidv4.0.0 (the pinned SHA) installstools platform-toolsby default. Google has removed the legacytoolspackage from the SDK repository, sosdkmanager toolsnow exits 1 and every job dies before the NDK is even set up. Nothing in this repo changed; the last green run on 2026-09-11 used the same workflow.Fix
Bump the pin to v4.0.4 (
be39fa83) in all four usages acrossnpm_release.ymlandpull_request.yml. Upstream fixed exactly this in v4.0.2 ("Fix for removed tools package") by changing the defaultpackagestoplatform-tools; v4.0.3/v4.0.4 are dependency and cmdline-tools updates.Note: #2047 carries an equivalent workaround (
with: packages: platform-toolson the old pin). Whichever lands second will need a trivial rebase of those hunks; this PR is the standalone fix somainis unblocked independently of that review.Summary by CodeRabbit