Skip to content

build: CMake 4.1.2 for the runtime native build - #2051

Merged
edusperoni merged 1 commit into
mainfrom
chore/cmake-4.1.2
Sep 22, 2026
Merged

edusperoni merged 1 commit into
mainfrom
chore/cmake-4.1.2

Conversation

@edusperoni

@edusperoni edusperoni commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Bumps the CMake used to build the runtime's native code from 3.31.6 to 4.1.2, the latest on the stable channel of Google's SDK repository, in both workflows and runtime/build.gradle.

Why it is safe

  • The runtime's CMakeLists.txt asks for 3.18.1, above the 3.5 floor CMake 4 still accepts.
  • Only the runtime AAR build in this repo uses the version. Nothing shipped to apps invokes CMake: the copied app/build.gradle mentions it only in commented-out code, and apps consume the prebuilt AAR. User projects are unaffected.

Verified locally with cmake;4.1.2 from the SDK manager: :runtime:assembleDebug -Pabis=arm64-v8a --warning-mode all builds the AAR, CMakeCache.txt shows sdk/cmake/4.1.2/bin/cmake, and there are no CMake deprecation or policy warnings in the output.

Summary by CodeRabbit

  • Chores
    • Updated the CMake version used for app builds, tests, and pull request checks to 4.1.2.

The SDK repository's stable channel now offers CMake 4.1.2, and the runtime's
CMakeLists only asks for 3.18.1, which is above the 3.5 floor CMake 4 still
accepts. Only the runtime AAR build here uses this version; the scripts shipped
to apps never invoke CMake.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 9df9e50e-6910-4b49-af02-a37836c2b03e

📥 Commits

Reviewing files that changed from the base of the PR and between b6f5f7c and 8c83e9f.

📒 Files selected for processing (3)
  • .github/workflows/npm_release.yml
  • .github/workflows/pull_request.yml
  • test-app/runtime/build.gradle

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The NPM release workflow, pull request workflow, and test app build configuration now specify CMake 4.1.2 instead of 3.31.6.

Changes

CMake version update

Layer / File(s) Summary
CMake version settings
.github/workflows/npm_release.yml, .github/workflows/pull_request.yml, test-app/runtime/build.gradle
All three configuration locations change the CMake version from 3.31.6 to 4.1.2.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: nathanwalker

Merge Risk: ⚪ Minimal · up to 8c83e

The CMake update is consistent across the runtime configuration and release setup. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the CMake version update for the runtime native build, which is the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the build once more
CMake’s version changed at the door
Release and pull request align
The test app follows the line
Ears perk up; the settings agree
And hops proceed through greenery

Comment @coderabbitai help to get the list of available commands.

@edusperoni
edusperoni merged commit 6d16eb2 into main Sep 22, 2026
8 checks passed
@edusperoni
edusperoni deleted the chore/cmake-4.1.2 branch September 22, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant