build: CMake 4.1.2 for the runtime native build - #2051
Conversation
The SDK repository's stable channel now offers CMake 4.1.2, and the runtime's CMakeLists only asks for 3.18.1, which is above the 3.5 floor CMake 4 still accepts. Only the runtime AAR build here uses this version; the scripts shipped to apps never invoke CMake.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe NPM release workflow, pull request workflow, and test app build configuration now specify CMake 4.1.2 instead of 3.31.6. ChangesCMake version update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The CMake update is consistent across the runtime configuration and release setup. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the build once more Comment |
Bumps the CMake used to build the runtime's native code from 3.31.6 to 4.1.2, the latest on the stable channel of Google's SDK repository, in both workflows and
runtime/build.gradle.Why it is safe
CMakeLists.txtasks for 3.18.1, above the 3.5 floor CMake 4 still accepts.app/build.gradlementions it only in commented-out code, and apps consume the prebuilt AAR. User projects are unaffected.Verified locally with
cmake;4.1.2from the SDK manager::runtime:assembleDebug -Pabis=arm64-v8a --warning-mode allbuilds the AAR,CMakeCache.txtshowssdk/cmake/4.1.2/bin/cmake, and there are no CMake deprecation or policy warnings in the output.Summary by CodeRabbit