Skip to content

bootstrap: create /usr/local/bin before installing the node agent #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SHOKOVprod merged 3 commits into from
Oct 15, 2026
Merged

bootstrap: create /usr/local/bin before installing the node agent #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ae3075
Update bootstrap.go
ANHELL404 Oct 14, 2026
81f79fe
Update install-node.sh
ANHELL404 Oct 14, 2026
145d511
bootstrap: create /usr/local/bin for every agent source; test order
SHOKOVprod Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/bootstrap/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1621,6 +1621,7 @@ ufw status | grep -qx 'Status: active'
`, fallbackSSHPort)
}
return fmt.Sprintf(`set -eu
install -d -m 0755 /usr/local/bin
%sinstall -m 0755 %s /usr/local/bin/nodeflow-node-agent.new
mv -f /usr/local/bin/nodeflow-node-agent.new /usr/local/bin/nodeflow-node-agent
%s
Expand Down
2 changes: 2 additions & 0 deletions internal/bootstrap/bootstrap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ func TestInstallScriptAptOnlyOnDebianFamily(t *testing.T) {
assert.Contains(t, ubuntu, "IOWeight=20")
assert.Contains(t, ubuntu, "TasksMax=64")
assert.Contains(t, ubuntu, "mv -f /usr/local/bin/nodeflow-node-agent.new")
assert.Less(t, strings.Index(ubuntu, "install -d -m 0755 /usr/local/bin\n"), strings.Index(ubuntu, "/usr/local/bin/nodeflow-node-agent.new"))
assert.GreaterOrEqual(t, strings.Index(ubuntu, "install -d -m 0755 /usr/local/bin\n"), 0)
assert.Contains(t, ubuntu, "systemctl restart nodeflow-node-agent.service")
assert.Contains(t, ubuntu, "systemctl is-active --quiet nodeflow-node-agent.service")
assert.NotContains(t, ubuntu, "ufw --force enable")
Expand Down
1 change: 1 addition & 0 deletions scripts/install-node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ main() {
;;
esac

install -d -m 0755 /usr/local/bin
if [[ -n ${NODE_AGENT_BINARY:-} ]]; then
install -m 0755 "${NODE_AGENT_BINARY}" /usr/local/bin/nodeflow-node-agent.new
elif [[ ${NODEFLOW_AGENT_SOURCE:-release} == build ]]; then
Expand Down
Loading