Repository navigation
Conversation
wavehassman
requested changes
Oct 26, 2026
wavehassman
left a comment
wavehassman
left a comment
Contributor
There was a problem hiding this comment.
great job! just a couple things
| if (!currentCompetitionPerformance) { | ||
| throw new NotFoundException('Competition Performance', competitionPerformanceId); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
also need to check if the performance has been deleted
|
|
||
| execSummaryRouter.post( | ||
| '/competition-performance/:competitionPerformanceId/edit', | ||
| body('finalPlace').optional({ nullable: true }).isInt(), |
Contributor
There was a problem hiding this comment.
i would drop nullable:true on all of these
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added the editCompetitionPerformance route, service, and controller as per the ticket. It authenticates that the user is an Admin/Ops team member the same way that editExecutiveSummary does. Added a createTestCompetitionPerformance to test utils and created unit tests for the endpoint itself
Test Cases
Screenshots
Manual Testing:
before
request
after
Closes #4606