Repository navigation
Fix dead links and anchors in the documentation - #826
Open
chenyangsu wants to merge 1 commit into
Open
chenyangsu wants to merge 1 commit into
chenyangsu wants to merge 1 commit into
Conversation
Four links return 404 because their targets moved: - faq.qmd: CodeExcerpts/DerivedTables was removed; the era scripts now live on the SQL Scripts page (sqlScripts.html#era-tables). - indices-primary-foreign.qmd: there is no v5.4 branch or tag; point the CSV and Redshift DDL links at main/inst/. - cdm54erd.qmd: the printable ERD moved from rmd/images to site/man/images. The Quarto migration changed heading anchors to lowercase, hyphenated ids, so these links open the right page but not the right section: - sqlScripts.html#drug_eras / #condition_eras (DRUG_ERA and CONDITION_ERA table descriptions, v5.3-v5.5) and #Source_to_Standard. - dataModelConventions.html#concept_relationships (v5.3-v5.5 field specs). - cdm54.html#CONDITION_ERA etc. in the FAQ (upper case; one also misspelled CONDITION_OCCURENCE) and #Standardized-Vocabularies -> #vocabulary-tables. - cdm531.html is now a stub that points to cdm53.html, so its #death, #payer_plan_period, #condition_era and #observation anchors moved there. Re-rendered the affected pages and kept only the link changes in docs/.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some links on the site either 404 or open the right page at the top instead of the right section.
404s (targets moved)
site/faq.qmdtree/master/CodeExcerpts/DerivedTablessqlScripts.html#era-tablessite/indices-primary-foreign.qmdtree/v5.4/inst/csvtree/main/inst/csvsite/indices-primary-foreign.qmdblob/v5.4/ddl/5.4/redshift/…_ddl.sqlblob/main/inst/ddl/5.4/redshift/…_ddl.sqlsite/cdm54erd.qmdraw/main/rmd/images/erd.jpgraw/main/site/man/images/erd.jpgAnchors broken by the Quarto migration. Quarto ids are lowercase and use hyphens, so these fragments no longer match (same kind of fix as #810):
sqlScripts.html#drug_erasand#condition_eras, from the DRUG_ERA and CONDITION_ERA table descriptions in the v5.3, v5.4 and v5.5 Table_Level CSVs. Also#Source_to_StandardincustomConcepts.qmd.dataModelConventions.html#concept_relationships, from the v5.3, v5.4 and v5.5 Field_Level CSVs.cdm54.html#CONDITION_ERA,#DRUG_EXPOSUREand similar infaq.qmd. One was also misspelled,#CONDITION_OCCURENCE. Also#Standardized-Vocabularies→#vocabulary-tables.cdm531.html#death,#payer_plan_period,#condition_eraand#observation(v5.3 Table_Level CSV andcdm60.qmd).cdm531.htmlis now a stub that points tocdm53.html, where those sections exist.Check: after the change, every
ohdsi.github.io/CommonDataModel/…#anchorlink insite/*.qmdand the v5.3, v5.4 and v5.5 CSVs matches anidin the rendereddocs/page. The three new GitHub URLs return 200.I re-rendered the eight affected pages and kept only the link hunks in
docs/, because my local Quarto is 1.10.20, not 1.10.18. This branch and #825 merge cleanly in either order.