Repository navigation
Restore the codespell config and keep it out of the R package build - #828
Open
chenyangsu wants to merge 1 commit into
Open
chenyangsu wants to merge 1 commit into
chenyangsu wants to merge 1 commit into
Conversation
The Codespell workflow has failed on main since the config was removed for the CRAN submission (aa047a3): without it, codespell flags hundreds of false positives in docs/site_libs, the archived PDFs and terms such as EHR. - Restore .codespellrc from before aa047a3. Widen its ignore-regex from PNG to any base64 image, since newer codespell dictionaries flag letters inside the JPEG embedded in extras/archive/OMOP_CDM_PDF.html. - Add ^\.codespellrc$ to .Rbuildignore so R CMD check does not report it as a hidden file, which is why it was removed. - Fix "suport" in NEWS.md, the one real typo left. codespell 2.4.3 now reports 0 problems, and R CMD build produces a tarball with no hidden files.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Check for spelling errors" job has failed on
main, and so on every PR, since.codespellrcwas removed for the CRAN submission in aa047a3. Without the config, codespell reports hundreds of false positives fromdocs/site_libs, the archived PDFs, and terms such as EHR, infarction and pilon. @DG47 suggested this fix in #822.Change
.codespellrcexactly as it was before aa047a3, with one edit:ignore-regexnow matches any base64 image (data:image/[a-z]+;base64) instead of only PNG. Newer codespell dictionaries flag letters inside the JPEG embedded inextras/archive/OMOP_CDM_PDF.html.^\.codespellrc$to.Rbuildignore, soR CMD checkno longer reports a hidden file. That was the reason for removing it.NEWS.md, the one real typo left.Check
codespell --count .(2.4.3, the version the action installs) reports 0.R CMD buildproducesCommonDataModel_1.1.0.tar.gzwith no hidden files.