Repository navigation
Use lowercase value_as_source_concept_id in the v5.5 DDL - #829
Open
chenyangsu wants to merge 1 commit into
Open
chenyangsu wants to merge 1 commit into
chenyangsu wants to merge 1 commit into
Conversation
b1cc2a0 made the column name consistently lowercase in the v5.5 field spec, but the v5.5 DDL was last generated before that commit, so v5.5.0 shipped value_as_source_concept_Id in the measurement and observation tables and in the fpk_*_value_as_source_concept_Id constraint names, in all dialects. Lowercase the 58 occurrences across the 29 ddl and constraints files. A fresh buildRelease() of v5.5 now matches these files apart from the float type SqlRender emits for duckdb and postgresql (NUMERIC vs DOUBLE), which is unrelated and also differs for v5.3 and v5.4.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b1cc2a0 made
value_as_source_concept_idconsistently lowercase in the v5.5 field spec on 19 Aug. The v5.5 DDL was last generated on 14 Aug, before that change. So the v5.5.0 scripts still createvalue_as_source_concept_Idinmeasurementandobservation, and name the constraintsfpk_measurement_value_as_source_concept_Idandfpk_observation_value_as_source_concept_Id. This affects all 16 dialects.Most databases fold unquoted identifiers, so queries still work. But the column comes back as
value_as_source_concept_Idin metadata on engines that preserve case (e.g. DuckDB, BigQuery), so tools that compare column names exactly against the spec CSV will see a mismatch.Change: lowercase the 58 occurrences in the 29 v5.5
ddlandconstraintsfiles. No other lines change.Check
buildRelease(cdmVersions = "5.5")(SqlRender 1.19.7) now matches these files, apart from the float type emitted for duckdb and postgresql (NUMERICvsDOUBLE/DOUBLE PRECISION). That difference comes from the SqlRender version, also shows up for v5.3 and v5.4, and I left it alone.This is probably 5.5.1 material, like #814.