Repository navigation
fix(harvester): skip deleted files in incremental runs - #1234
Open
Yeagerist0 wants to merge 1 commit into
Open
Yeagerist0 wants to merge 1 commit into
Yeagerist0 wants to merge 1 commit into
Conversation
Yeagerist0
requested review from
Pa04rth,
northdpole,
paoga87 and
robvanderveer
as code owners
November 16, 2026 06:32
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1192. Incremental harvesting now excludes files deleted between the checkpoint and the target commit. Previously
git diff --name-onlyreturned deleted paths, and_harvest_repository()tried to read them from the target commit. That raised an error before the checkpoint could advance, leaving the repository stuck on every later run.Use Git's
--diff-filter=dso added, modified, and renamed files remain candidates while deleted paths are omitted. A real-repository integration test covers one edited file alongside one deleted file; the test failed before the change and passes now.Verification
change_detector.py: passedAI assistance was used to prepare the fix and regression test. I reviewed the diff and ran the checks locally.